[Doctrine] SearchFilter - Use abitrary index instead of value#5079
Merged
Conversation
Korbeil
force-pushed
the
fix/parameter-not-set
branch
3 times, most recently
from
October 21, 2022 10:04
0c4a2ed to
729aca1
Compare
welcoMattic
approved these changes
Oct 21, 2022
Member
|
Could you please add unit tests? |
Korbeil
force-pushed
the
fix/parameter-not-set
branch
2 times, most recently
from
October 21, 2022 12:40
fa45aac to
9ca1f93
Compare
Contributor
Author
Is that enough ? Not sure what I could add more 🤔 |
Member
Yes, that's enough 🙂 You need to change the |
Contributor
|
nice catch |
Member
|
how was this in 2.6 ? I think that we could fix this on 3.0 instead, 2.7 should have only bc-layer related fixes. Unless this was wrongly introduced in 2.7 we may fix it here. |
Korbeil
force-pushed
the
fix/parameter-not-set
branch
from
October 21, 2022 13:43
9ca1f93 to
3b89b7e
Compare
Contributor
Author
I do think this was here since a long time, I'll change the branch to |
Korbeil
force-pushed
the
fix/parameter-not-set
branch
from
October 21, 2022 14:13
3b89b7e to
b4a9ba7
Compare
Member
|
Thanks @Korbeil ! |
soyuka
added a commit
that referenced
this pull request
Nov 4, 2022
* fix: update yaml extractor test file coding standard (#5068) * fix(graphql): add clearer error message when TwigBundle is disabled but graphQL clients are enabled (#5064) * fix(metadata): add class key in payload argument resolver (#5067) * fix: add class key in payload argument resolver * add null if everything else goes wrong * fix: upgrade command remove ApiSubresource attribute (#5049) Fixes #5038 * fix(doctrine): use abitrary index instead of value (#5079) * fix: uri template should respect rfc 6570 (#5080) * fix: remove @internal annotation for Operations (#5089) See #5084 * fix(metadata): define a name on a single operation (#5090) fixes #5082 * fix(metadata): deprecate when user decorates in legacy mode (#5091) fixes #5078 * fix(graphql): use right nested operation (#5102) * Revert "fix(graphql): use right nested operation (#5102)" (#5111) This reverts commit 44337dd. * fix(graphql): always allow to query nested resources (#5112) * fix(graphql): always allow to query nested resources * review Co-authored-by: Alan Poulain <contact@alanpoulain.eu> * chore: php-cs-fixer update * fix: only alias if exists for opcache preload Fixes api-platform/api-platform#2284 (#5110) Co-authored-by: Liviu Mirea <liviu.mirea@wecodepixels.com> * chore: php-cs-fixer update (#5118) * chore: php-cs-fixer update * chore: php-cs-fixer update * fix(metadata): upgrade script keep operation name (#5109) origin: #5105 Co-authored-by: WilliamPeralta <william.peralta18@gmail.com> * chore: v2.7.3 changelog * chore: v3.0.3 changelog Co-authored-by: helyakin <CourcierMarvin@gmail.com> Co-authored-by: ArnoudThibaut <thibaut.arnoud@gmail.com> Co-authored-by: davy-beauzil <38990335+davy-beauzil@users.noreply.github.com> Co-authored-by: Baptiste Leduc <baptiste.leduc@gmail.com> Co-authored-by: Xavier Laviron <norival@users.noreply.github.com> Co-authored-by: Alan Poulain <contact@alanpoulain.eu> Co-authored-by: Liviu Cristian Mirea-Ghiban <contact@liviucmg.com> Co-authored-by: Liviu Mirea <liviu.mirea@wecodepixels.com> Co-authored-by: WilliamPeralta <william.peralta18@gmail.com>
alexndlm
added a commit
to eonx-com/easy-monorepo
that referenced
this pull request
Nov 7, 2022
alexndlm
added a commit
to eonx-com/easy-monorepo
that referenced
this pull request
Nov 18, 2022
alexndlm
added a commit
to eonx-com/easy-monorepo
that referenced
this pull request
Jan 13, 2023
natepage
pushed a commit
to eonx-com/easy-monorepo
that referenced
this pull request
May 21, 2023
* -create AdvancedSearchFilter * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -rollback * -sync with api-platform/core#5079 * -fix ecs * -fix typo * -refactoring * -fix ecs * -refactoring * -fix phpstan * -refactoring * -fix ecs * -update composer.json * -update composer.json * -rename Stubs to Fixtures * -rename Stubs to Fixtures * -rename Stubs to Fixtures * -refactoring * -refactoring * -fix phpstan * -rollback changes * -fix deps
natepage
pushed a commit
to eonx-com/easy-api-platform
that referenced
this pull request
May 21, 2023
* -create AdvancedSearchFilter * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -rollback * -sync with api-platform/core#5079 * -fix ecs * -fix typo * -refactoring * -fix ecs * -refactoring * -fix phpstan * -refactoring * -fix ecs * -update composer.json * -update composer.json * -rename Stubs to Fixtures * -rename Stubs to Fixtures * -rename Stubs to Fixtures * -refactoring * -refactoring * -fix phpstan * -rollback changes * -fix deps
natepage
pushed a commit
to eonx-com/easy-core
that referenced
this pull request
May 21, 2023
* -create AdvancedSearchFilter * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -fix dependencies * -rollback * -sync with api-platform/core#5079 * -fix ecs * -fix typo * -refactoring * -fix ecs * -refactoring * -fix phpstan * -refactoring * -fix ecs * -update composer.json * -update composer.json * -rename Stubs to Fixtures * -rename Stubs to Fixtures * -rename Stubs to Fixtures * -refactoring * -refactoring * -fix phpstan * -rollback changes * -fix deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a search filter with multiple values that have the same lowercase identity, for example:
SearchFilter will lowercase the value and use it as index key, which makes it send only one parameter to Doctrine when it needs two of them.
I choosed to leave the arbitrary array index so we don't have this kind of issues anymore.